Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set max jobs to auto #627

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Set max jobs to auto #627

merged 1 commit into from
Sep 13, 2023

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Sep 8, 2023 •
edited
Loading

Description

1 is the default on non-NixOS and that's lame.

https://nixos.org/manual/nix/stable/command-ref/conf-file.html#conf-max-jobs

Depends on #620

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.11.1 milestone Sep 8, 2023
@Hoverbear Hoverbear self-assigned this Sep 8, 2023
@Hoverbear Hoverbear marked this pull request as ready for review September 8, 2023 20:54
@Hoverbear Hoverbear removed the request for review from cole-h September 8, 2023 20:54
@Hoverbear Hoverbear marked this pull request as draft September 8, 2023 20:54
cole-h
cole-h approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the dependent PR is merged)

@Hoverbear Hoverbear force-pushed the hoverbear/ds-1236-set-max-jobs-to-auto branch 2 times, most recently from 6c92aec to 9ba0445 Compare September 13, 2023 17:14
@Hoverbear Hoverbear force-pushed the hoverbear/ds-1236-set-max-jobs-to-auto branch from 9ba0445 to c2430f8 Compare September 13, 2023 17:17
@Hoverbear Hoverbear marked this pull request as ready for review September 13, 2023 17:17
@Hoverbear Hoverbear enabled auto-merge (squash) September 13, 2023 17:18
@Hoverbear Hoverbear merged commit 1c103ed into main Sep 13, 2023
13 checks passed
@Hoverbear Hoverbear deleted the hoverbear/ds-1236-set-max-jobs-to-auto branch September 13, 2023 17:38
@Hoverbear Hoverbear mentioned this pull request Sep 28, 2023
Merged
6 tasks
mkenigs added a commit to flox/experimental-nix-installer that referenced this pull request Nov 9, 2023
@mkenigs
Document max-jobs=auto
c8e4a01 
max-jobs is set to auto as of
DeterminateSystems#627
@mkenigs mkenigs mentioned this pull request Nov 9, 2023
Merged
6 tasks
Hoverbear pushed a commit that referenced this pull request Nov 10, 2023
@mkenigs
Document max-jobs=auto (#712)
6ca2c68 
max-jobs is set to auto as of
#627
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h