Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make errors non-exhaustive #299

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Make errors non-exhaustive #299

merged 1 commit into from
Mar 3, 2023

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Mar 3, 2023

Description

Adding a new error variant shouldn't force us to bump the version due to being semver-incompatible.

Done with the following:

rg 'enum .+Error.* \{' --no-heading -n | cut -d: -f1-2 | while read file; hx "$file"; end
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Adding a new error variant shouldn't force us to bump the version due to
being semver-incompatible.
@cole-h cole-h added this to the v0.5.0 milestone Mar 3, 2023
@cole-h cole-h requested a review from Hoverbear March 3, 2023 19:55
@cole-h cole-h self-assigned this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants