Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deleting users and groups on Mac #253

Merged
merged 11 commits into from
Feb 22, 2023
Merged

Enable deleting users and groups on Mac #253

merged 11 commits into from
Feb 22, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

We're experimenting trying to enable this. Considered a WIP.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Feb 15, 2023
@Hoverbear Hoverbear added upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing MacOS Darwin/MacOS labels Feb 15, 2023
@Hoverbear Hoverbear marked this pull request as ready for review February 17, 2023 18:02
@Hoverbear
Copy link
Contributor Author

We need to go a little farther here -- On our ephemeral macs it's perfectly fine to delete a group without deleting the user, so we need to make sure on a reinstall if those users exist we go ahead and add them to the group...

cole-h
cole-h reviewed Feb 17, 2023
View reviewed changes
src/action/base/create_user.rs Show resolved Hide resolved
src/action/base/create_group.rs Show resolved Hide resolved
src/action/base/create_user.rs Outdated Show resolved Hide resolved
@Hoverbear Hoverbear marked this pull request as draft February 17, 2023 21:58
@Hoverbear Hoverbear removed the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Feb 17, 2023
@Hoverbear Hoverbear added this to the v0.3.1 milestone Feb 21, 2023
@Hoverbear Hoverbear marked this pull request as ready for review February 21, 2023 18:56
cole-h
cole-h reviewed Feb 21, 2023
View reviewed changes
src/action/base/add_user_to_group.rs Outdated Show resolved Hide resolved
src/action/base/add_user_to_group.rs Outdated Show resolved Hide resolved
src/action/base/create_group.rs Show resolved Hide resolved
src/action/common/create_users_and_groups.rs Show resolved Hide resolved
tests/plan.rs Outdated Show resolved Hide resolved
@Hoverbear Hoverbear merged commit 689cf84 into main Feb 22, 2023
@Hoverbear Hoverbear deleted the reenable-users-and-groups-on-mac branch February 22, 2023 15:46
@Hoverbear
Copy link
Contributor Author

Fixes #33.

@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
This was referenced May 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
MacOS Darwin/MacOS
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h