Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair some tests #248

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Repair some tests #248

merged 2 commits into from
Feb 13, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Repairs some of our pre-release tests to reflect recent changes.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the v0.3.0 milestone Feb 13, 2023
@Hoverbear Hoverbear self-assigned this Feb 13, 2023
cole-h
cole-h approved these changes Feb 13, 2023
View reviewed changes
nix/tests/container-test/default.nix Outdated
hash = "sha256-iTJR+DeC5lT4PMqT/xFAFwmlC/qvslDFccDrVFLt/a8=";
tarball = builtins.fetchurl {
url = "http://cdimage.ubuntu.com/ubuntu-base/releases/20.04/release/ubuntu-base-20.04.1-base-amd64.tar.gz";
sha256 = "sha256:0ryn38csmx41a415g9b3wk30csaxxlkgkdij9v4754pk877wpxlp";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't usually see the sha256: prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what nix outputs....
image

I'll yank it though.

@Hoverbear Hoverbear enabled auto-merge (squash) February 13, 2023 23:01
@Hoverbear Hoverbear merged commit 1c0c92f into main Feb 13, 2023
@Hoverbear Hoverbear deleted the repair-some-tests branch February 13, 2023 23:33
@lucperkins lucperkins mentioned this pull request Feb 20, 2023
Merged
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h