Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer users better error if fstab entries exist #241

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Due to #37 we can't really see if an apfs volume would be created, so we can't know if the fstab entry is already existing an correct (since creating an apfs volume would change the UUID and require the fstab to be updated). So we can only offer a nice error for now.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Feb 9, 2023
src/action/darwin/create_fstab_entry.rs Outdated Show resolved Hide resolved
src/action/darwin/create_fstab_entry.rs Outdated Show resolved Hide resolved
@Hoverbear Hoverbear modified the milestones: v0.2.1, v0.3.0 Feb 10, 2023
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after these last nits.

src/action/darwin/create_fstab_entry.rs Outdated Show resolved Hide resolved
src/action/darwin/create_fstab_entry.rs Outdated Show resolved Hide resolved
@Hoverbear Hoverbear enabled auto-merge (squash) February 10, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants