Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support existing files with CreateFile and CreateorInsertIntoFile #239

Merged
merged 12 commits into from
Feb 10, 2023

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Feb 6, 2023

Description

This makes it so if a file already exists where we would create or insert into it, we can check to see if we need to do anything, otherwise skip it.

Part of #35

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Feb 6, 2023
@Hoverbear Hoverbear added this to the v0.2.1 milestone Feb 7, 2023
src/action/base/create_directory.rs Outdated Show resolved Hide resolved
src/action/base/create_directory.rs Outdated Show resolved Hide resolved
src/action/base/create_file.rs Outdated Show resolved Hide resolved
src/action/base/create_file.rs Outdated Show resolved Hide resolved
src/action/base/create_file.rs Show resolved Hide resolved
src/action/base/create_or_insert_into_file.rs Outdated Show resolved Hide resolved
src/action/base/create_or_insert_into_file.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants