Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a friendly top comment about nix-installer.sh #216

Merged

Conversation

Hoverbear
Copy link
Contributor

Description

Some folks were a bit curious what the nix-installer.sh did, so we reworded the start to make it more friendly and explain quite directly what it does, as well as offering users a way to avoid using the script entirely.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Jan 30, 2023
@Hoverbear Hoverbear changed the title Add a friendly top comment about nix-installer.sh Add a friendly top comment about nix-installer.sh Jan 30, 2023
nix-installer.sh Outdated Show resolved Hide resolved
@Hoverbear Hoverbear added this to the v0.1.1 milestone Jan 31, 2023
@Hoverbear Hoverbear force-pushed the hoverbear/ds-644-explain-in-the-first-curl-sh-script-what branch from ac07db4 to d53798a Compare January 31, 2023 16:30
@Hoverbear Hoverbear requested a review from cole-h January 31, 2023 17:10
nix-installer.sh Outdated Show resolved Hide resolved
@Hoverbear Hoverbear enabled auto-merge (squash) January 31, 2023 17:32
@Hoverbear Hoverbear added the documentation Improvements or additions to documentation label Jan 31, 2023
@Hoverbear Hoverbear merged commit 6b3a840 into main Jan 31, 2023
@Hoverbear Hoverbear deleted the hoverbear/ds-644-explain-in-the-first-curl-sh-script-what branch January 31, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants