Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-append the subdir to the store path #82

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 21, 2023

In #81, we inadvertently appended the subdir to the path which already included the subdir when reading the readme. This causes publishing failures because the directory we expect the readme to exist in likely does not exist:

 INFO flakehub_push:push_new_release: Preparing release of grahamc/nix-starter-flakes/0.0.0 repository=grahamc/nix-starter-flakes mirror=false upload_name=grahamc/nix-starter-flakes
flake_store_path: "/nix/store/abg459275ipf6x32an2padhjjclx26ip-source/go"
readme_path: "/nix/store/abg459275ipf6x32an2padhjjclx26ip-source/go/go"

@grahamc grahamc requested a review from cole-h September 21, 2023 13:40
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I could have sworn there was a reason I kept that, but indeed it's broken on my flake-inside-a-directory test case... Oops.

@cole-h cole-h merged commit 30febd2 into main Sep 21, 2023
5 checks passed
@cole-h cole-h deleted the fix-publish-subdirectory branch September 21, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants