Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix macOS build" #143

Merged
merged 1 commit into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: DeterminateSystems/flake-checker-action@main

- uses: DeterminateSystems/nix-installer-action@main

- uses: DeterminateSystems/magic-nix-cache-action@main

- uses: DeterminateSystems/flake-checker-action@main

- name: "Nix formatting"
run: git ls-files '*.nix' | nix develop --command xargs nixpkgs-fmt --check

Expand All @@ -32,7 +32,7 @@ jobs:
run: nix develop --command cargo clippy --all-targets --all-features -- -Dwarnings

- name: "Nix Flake Check"
run: nix flake check --all-systems --print-build-logs
run: nix flake check --print-build-logs

- name: Build package
run: "nix build .# -L --fallback"
Expand All @@ -44,23 +44,3 @@ jobs:
name: flakehub-push-X64-Linux
path: result/bin/flakehub-push
retention-days: 1

# For local development purposes
build-artifacts-macos:
runs-on: ${{ matrix.systems.runner }}
strategy:
matrix:
systems:
- nix-system: aarch64-darwin
runner: macos-latest-xlarge
- nix-system: x86_64-darwin
runner: macos-12
steps:
- uses: actions/checkout@v3

- uses: DeterminateSystems/nix-installer-action@main

- uses: DeterminateSystems/magic-nix-cache-action@main

- name: Build package
run: "nix build .# -L --fallback"
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/dist
/src
pnpm-lock.yaml
flake.lock
101 changes: 54 additions & 47 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

58 changes: 25 additions & 33 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
url = "https://flakehub.com/f/ipetkov/crane/0.14.1.tar.gz";
inputs.nixpkgs.follows = "nixpkgs";
};
fenix = {
url = "https://flakehub.com/f/nix-community/fenix/0.1.1885.tar.gz";
rust-overlay = {
url = "github:oxalica/rust-overlay";
inputs.nixpkgs.follows = "nixpkgs";
};
};
Expand All @@ -24,50 +24,42 @@
inherit system;
pkgs = import inputs.nixpkgs {
inherit system;
overlays = [ inputs.self.overlays.default ];
overlays = [
inputs.self.overlays.default
inputs.rust-overlay.overlays.default
];
};
lib = pkgs.lib;
});
in
{
overlays.default = final: prev: rec {
system = final.stdenv.hostPlatform.system;

rustToolchain = with inputs.fenix.packages.${system};
combine ([
stable.clippy
stable.rustc
stable.cargo
stable.rustfmt
stable.rust-src
] ++ final.lib.optionals (system == "x86_64-linux") [
targets.x86_64-unknown-linux-musl.stable.rust-std
] ++ final.lib.optionals (system == "aarch64-linux") [
targets.aarch64-unknown-linux-musl.stable.rust-std
]);

craneLib = (inputs.crane.mkLib final).overrideToolchain rustToolchain;

overlays.default = final: prev: {
flakehub-push = inputs.self.packages.${final.stdenv.system}.flakehub-push;
};

packages = forAllSystems ({ system, pkgs, ... }: rec {
default = flakehub-push;
packages = forAllSystems ({ system, pkgs, lib, ... }:
let
craneLib = (inputs.crane.mkLib pkgs).overrideToolchain rustToolchain;
rustToolchain = pkgs.rust-bin.stable.latest.default.override {
targets = [ "x86_64-unknown-linux-musl" ];
};
in
rec {
default = flakehub-push;

flakehub-push = pkgs.craneLib.buildPackage
{
flakehub-push = craneLib.buildPackage {
pname = "flakehub-push";
version = "0.1.0";
src = pkgs.craneLib.path ./.;
src = craneLib.path ./.;

buildInputs = pkgs.lib.optionals (pkgs.stdenv.isDarwin) (with pkgs; [
libiconv
CARGO_BUILD_TARGET = "x86_64-unknown-linux-musl";
CARGO_BUILD_RUSTFLAGS = "-C target-feature=+crt-static";

buildInputs = lib.optionals (pkgs.stdenv.isDarwin) (with pkgs; [
darwin.apple_sdk.frameworks.SystemConfiguration
]);
} // pkgs.lib.optionalAttrs pkgs.stdenv.isLinux {
CARGO_BUILD_TARGET = "x86_64-unknown-linux-musl";
CARGO_BUILD_RUSTFLAGS = "-C target-feature=+crt-static";
};
});
};
});

devShells = forAllSystems ({ system, pkgs, ... }: {
default = pkgs.mkShell {
Expand Down
Loading