(WIP) Less GitHub dependence #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
commented
Feb 16, 2024
|
|
||
| assert!(subdir.is_relative()); | ||
|
|
||
| let revision_count = match revision_info.local_revision_count { |
There was a problem hiding this comment.
This code was effectively dead, we'd not actually use revision_count anywhere except on L127 on the span.record.
Hoverbear
commented
Feb 16, 2024
| @@ -434,24 +458,56 @@ impl FlakeHubPushCli { | |||
| } | |||
| }; | |||
|
|
|||
| let commit_count = github_graphql_data_result.rev_count; | |||
There was a problem hiding this comment.
Hoverbear
commented
Feb 16, 2024
| Ok(ReleaseMetadata { | ||
| description, | ||
| repo: upload_name.to_string(), | ||
| raw_flake_metadata: flake_metadata.clone(), | ||
| readme, | ||
| revision: revision_info.revision, | ||
| commit_count: github_graphql_data_result.rev_count, |
There was a problem hiding this comment.
Notice how this matches with the apparent logic change above.
|
Sigh, this is going to roll into #109 since it's no longer just becoming a pure-code-move PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #110 to re-implement #108