Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.19.1 regression: Failed to parse pyproject.toml when it contains emoji #819

Closed
shoucandanghehe opened this issue Oct 27, 2024 · 4 comments · Fixed by #822
Closed

1.19.1 regression: Failed to parse pyproject.toml when it contains emoji #819

shoucandanghehe opened this issue Oct 27, 2024 · 4 comments · Fixed by #822
Labels
config issues relating to config (pyproject.toml, pyrightconfig.json, LSP config or vscode extension)

Comments

@shoucandanghehe
Copy link

f5d7f3f941fbd17585308afd97086db0
b14b399385381c8b9e1249513cc42214
It can be solved by using the GitHub Markdown style emoji like :bookmark:
shoucandanghehe added a commit to A-Minos/nonebot-plugin-tetris-stats that referenced this issue Oct 27, 2024
@shoucandanghehe
💚 修复 basedpyright
b3a77f5 
DetachHead/basedpyright#819
@KotlinIsland
Copy link
Collaborator

the toml parser was changed in version 1.19.1, was this working previously?

@KotlinIsland KotlinIsland added the config issues relating to config (pyproject.toml, pyrightconfig.json, LSP config or vscode extension) label Oct 27, 2024
@shoucandanghehe
Copy link
Author

the toml parser was changed in version 1.19.1, was this working previously?

yes, i tested 1.19.0 and it work fine

@KotlinIsland KotlinIsland changed the title Failed to parse pyproject.toml when it contains emoji 1.19.1 regression: Failed to parse pyproject.toml when it contains emoji Oct 27, 2024
@DetachHead
Copy link
Owner

raised upstream at sunnyadn/js-toml#2

in the mean time i'll see if i can find another toml parser. but there doesn't seem to be many options

@KotlinIsland
Copy link
Collaborator

https://jsr.io/@std/toml could we use this?

@DetachHead DetachHead mentioned this issue Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
config issues relating to config (pyproject.toml, pyrightconfig.json, LSP config or vscode extension)
Projects
None yet
Milestone
No milestone
3 participants
@shoucandanghehe @DetachHead @KotlinIsland