Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add D3 OSS contributors to the credits #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lgt2x
Copy link
Member

@Lgt2x Lgt2x commented Sep 2, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Add this project's contributor names at the end of the credits. Every contributor with at least 1 commit in the main branch has their name. Use full name if available publicly on GitHub, handle only otherwise. If anyone does not wish to be there or wants their name changed, feel free to say so. Non-ASCII have been converted because they did not display correctly (ß -> ss, sorry @pzychotic ).

To be updated before each release.

Related Issues

Close #563

Screenshots (if applicable)

credits

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@pzychotic
Copy link
Contributor

Non-ASCII have been converted because they did not display correctly (ß -> ss, sorry @pzychotic ).

No worries, I'm used to that ;)
Nice touch, though.

@MaddTheSane
Copy link
Contributor

I like my nickname spelled out as "Madd the Sane", with the spaces.
On the other hand, if you're just mentioning the GitHub user name and not a nickname, you can ignore my comment.

@Lgt2x
Copy link
Member Author

Lgt2x commented Sep 16, 2024

I like my nickname spelled out as "Madd the Sane", with the spaces. On the other hand, if you're just mentioning the GitHub user name and not a nickname, you can ignore my comment.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contributor names to the credits
4 participants