Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new measures to Tane #458

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Add new measures to Tane #458

merged 5 commits into from
Oct 21, 2024

Conversation

egshnov
Copy link
Contributor

@egshnov egshnov commented Sep 10, 2024

This pr implements mining of afds based on error measures pdep, tau, mu_plus, rho as in "Measuring Approximate Functional Dependencies: A Comparative Study"

@egshnov egshnov mentioned this pull request Sep 21, 2024
@egshnov egshnov changed the title Implement mining of Afds based on pdep \tau mu+ and \rho measures Add new measures to Tane Sep 25, 2024
@egshnov egshnov force-pushed the new_measures branch 2 times, most recently from 6cc9df8 to f5f08e9 Compare September 25, 2024 22:57
@egshnov egshnov marked this pull request as ready for review September 25, 2024 22:57
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/algorithms/fd/tane/pfdtane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/tests/test_tane_afd_measures.cpp Show resolved Hide resolved
@egshnov egshnov force-pushed the new_measures branch 2 times, most recently from 4b68322 to 4fde4bf Compare September 26, 2024 21:09
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/tests/test_tane_afd_measures.cpp Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.h Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@chernishev chernishev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dmitriy Shcheka looked into and approved

@chernishev chernishev merged commit f790b62 into Desbordante:main Oct 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants