Add script for testing examples #399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add script for testing examples (without gfd). Bindings now return sorted list of fds (only for algos inherited from FDAlgorithm). Update README to the current output
DaniilGoncharov
force-pushed
the
test_examples
branch
from
79d3a5b
to
9b7fad7
Compare
polyntsov
reviewed
May 1, 2024
Comment on lines
+45
to
+47
| bool operator<(Vertical const& rhs) const { | ||
| return column_indices_ < rhs.column_indices_; | ||
| } |
There was a problem hiding this comment.
Why do we change this operator< behavior?
Given the comment above (@brief section), we are not using operator< of bitsets intentionally
polyntsov
reviewed
May 1, 2024
| @@ -0,0 +1,40 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
It looks like we are reinventing cram tests: https://bitheap.org/cram/
I'm not sure we want to use this exact library, because it seems unsupported, but there is the example which shows the idea. The concept is suitable for our use case, we only need to find a good tool implementing cram testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add script for testing examples (without gfd). Bindings now return sorted list of fds (only for algos inherited from FDAlgorithm). Update README to the current output