Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In dev #234

Closed

Conversation

Popov-Dmitriy-Ivanovich
Copy link
Contributor

added cast system for numeric type

@polyntsov
Copy link
Collaborator

О правилах наименовая коммитов и пулреквестов есть в wiki, прочти. Пулреквесты в разработке можно помечать как draft

@polyntsov polyntsov marked this pull request as draft July 29, 2023 21:00
…it to model::CastToCppType in model::NumericType template
@Popov-Dmitriy-Ivanovich
Copy link
Contributor Author

added cast system for numeric type

Removed warnings during compilation, hope tests will pass. Have no idea what to do with clang-format-check

@polyntsov
Copy link
Collaborator

Removed warnings during compilation, hope tests will pass. Have no idea what to do with clang-format-check

You can click the "details" button next to the check and then the "summary" button in the upper left corner, a page will appear with all the formatting violations in your patches that need to be fixed. You can do it either manually, or by using clang-format tool, but please apply automatic formatting only on your changes, not entire files.

Also the commit messages still have incorrect naming style, follow the commit message rules (taken from our wiki).
And, please, try to keep commit history as clean as possible, prefer overwriting existing commits with useful functionality instead of adding new commits with "fixups" (useful blog post on the topic https://mainmatter.com/blog/2021/05/26/keeping-a-clean-git-history/, especially the "Smallest number of commits for the smallest conceptual change" paragraph).

@Popov-Dmitriy-Ivanovich
Copy link
Contributor Author

Думаю лучше будет починить названия коммитов закомитив их в другую ветку и PR кинуть оттуда

@polyntsov
Copy link
Collaborator

Все равно скорее всего придется исправлять существующие коммиты после ревью, поэтому не очень понятно, зачем нужна новая ветка и отдельный pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants