Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace update workflow state methods with DAO queries #984

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Nov 27, 2024

Description

Replace update workflow state method with DAO queries + remove the method not in use.

Addressed Issue

NA

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added the enhancement New feature or request label Nov 27, 2024
Copy link

codacy-production bot commented Nov 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0ab3cb0) 22251 18403 82.71%
Head commit (aef7fcb) 22227 (-24) 18380 (-23) 82.69% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#984) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the more JDBI the better! :D

Just a note on connection usage, otherwise looks good!

@nscuro nscuro added this to the 5.6.0 milestone Nov 28, 2024
@nscuro nscuro merged commit fa884a4 into main Nov 28, 2024
9 checks passed
@nscuro nscuro deleted the update-workflow-state-sql branch November 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants