Merge cleanup tasks into a single Housekeeping task #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nscuro <[email protected]>
It doesn't make sense that plugins are defined by DT, and cannot be provided by users. Instead, DT defines "extension points", for which plugins can provide implementations ("extensions").
This change also enabled plugins to provide multiple extensions, not just one.
Signed-off-by: nscuro <[email protected]>
Making it easier to eventually move the API to a separate module altogether. Signed-off-by: nscuro <[email protected]>
Plugin and extension names are not necessarily unique, but in combination with their classes, they should be. So always include both the name and class in log statements to avoid any ambiguity. Make use of MDC to ensure consistent inclusion of contextual information in log statement. Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning
This PR is based on #805 and #794.
Merges cleanup tasks into a single Housekeeping task.
Addressed Issue
N/A
Additional Details
Before #794, we already had:
VulnerabilityScanCleanupTask: Deletes allVULNERABILITYSCANrecords that have not been updated for over an hour.WorkflowStateCleanupTaskWORKFLOW_STATErecords fromSTATUS=PENDINGtoSTATUS=TIMED_OUTthat have not been updated for a configurable duration.WORKFLOW_STATErecords fromSTATUS=TIMED_OUTtoSTATUS=FAILEDthat have not been updated for a configurable duration.WORKFLOW_STEPrecords that had their parent transitioned toSTATUS=FAILEDWORKFLOW_STATErecords that have not been updated for a configurable retention time.With #794, a new task for enforcing BOM upload retention would've been necessary. And there are more cases in which we'd benefit from retention enforcement (added
TODOs in the code for those).It's easier to configure, and reason about these things if there's only a single task that executes them.
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly