Port: Refactor BOM upload processing for better efficiency, correctness, and consistency #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
added
enhancement
2 tasks
nscuro
force-pushed
the
port-pr-3357
branch
2 times, most recently
from
aaf9c9d to
0cabbae
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
2 tasks
…d consistency Ports DependencyTrack/dependency-track#3357 from Dependency-Track v4.11.0 The majority of changes already existed in the Hyades codebase, since they were originally ported from Hyades to DT :) The following changes were NOT ported: * `IndexingInstanceLifecycleListener`: Lucene was removed in Hyades, keeping the index current is not a concern * `L2CacheEvictingInstanceLifecycleListener`: The L2 cache has been disabled globally in Hyades, invalidating L2 cache entries is not a concern * The `ConfigKey.BOM_PROCESSING_TASK_V2_ENABLED`: The legacy BOM processing task no longer exists in Hyades, hence making this config useless Signed-off-by: nscuro <[email protected]>
src/main/java/org/dependencytrack/util/InternalComponentIdentificationUtil.java
Outdated
Show resolved
Hide resolved
It doesn't serve any real purpose anymore. Signed-off-by: nscuro <[email protected]>
sahibamittal
approved these changes
Jun 11, 2024
nscuro
added a commit
that referenced
this pull request
Jun 11, 2024
Ports DependencyTrack/dependency-track#3555 from Dependency-Track v4.11.0. The main logic was already ported via #705. This PR contains the missing test case. Co-authored-by: Aravind Parappil <[email protected]> Signed-off-by: nscuro <[email protected]>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports DependencyTrack/dependency-track#3357 from Dependency-Track v4.11.0
Addressed Issue
Relates to DependencyTrack/hyades#1190
Additional Details
The majority of changes already existed in the Hyades codebase, since they were originally ported from Hyades to DT :)
The following changes were NOT ported:
IndexingInstanceLifecycleListener: Lucene was removed in Hyades, keeping the index current is not a concernL2CacheEvictingInstanceLifecycleListener: The L2 cache has been disabled globally in Hyades, invalidating L2 cache entries is not a concernConfigKey.BOM_PROCESSING_TASK_V2_ENABLED: The legacy BOM processing task no longer exists in Hyades, hence making this config uselessChecklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly