-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale picker to header #824
Conversation
@fnxpt Fancy giving this a review? Besides the code itself, please have a look at the new translations. For German, the auto-translate suggested "polieren" for "Polish" (as in polishing, the verb lol). |
This is to make it easier to switch languages, without having to fiddle with browser settings. Signed-off-by: nscuro <[email protected]>
…e.*` Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an additional comment, I would add flags instead of text, usually on these types of selectors its more common to see a flag
Thanks @fnxpt!
Good point. I briefly looked into that but couldn't be bothered to add yet another NPM package just for flag icons. I'll have another look, I agree that country codes might be sub-optimal. |
We can also add the images on the resources and just do {locale}.png, no need for an extra library |
@fnxpt Any good source for flag icons you can recommend? |
Thanks @fnxpt for the suggestion! Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
@fnxpt Suggestions applied. Updated the GIF in the PR description to show the current look&feel of the language picker. Can you have another look please? |
lgtm |
Description
Adds a locale picker to the header of the page, next to the profile icon.
This is to make it easier to switch languages, without having to fiddle with browser settings.
Addressed Issue
N/A
Additional Details
Current version (don't ask me why the GIF quality is worse, no idea):
Original version:
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly