Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Enhance policy violation de-duplication logic #4235

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Oct 9, 2024

Description

Enhances the policy violation de-duplication logic introduced in #4216.

Addressed Issue

Relates to #4215
Backports #4231

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Instead of just discarding *any* duplicate, compare them first, and only keep the most "useful" one.

DependencyTrack#4215 (comment)
Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Oct 9, 2024
@nscuro nscuro added this to the 4.12.1 milestone Oct 9, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 70.37% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (da44db1) 22520 17831 79.18%
Head commit (d40d3af) 22545 (+25) 17849 (+18) 79.17% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4235) 27 19 70.37%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 9117383 into DependencyTrack:4.12.x Oct 9, 2024
8 checks passed
@nscuro nscuro deleted the backport-pr-4231 branch October 9, 2024 20:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant