Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Trivy integration to use Protobuf instead of JSON #4116

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 2, 2024

Description

Migrate Trivy integration to use Protobuf instead of JSON.

Addressed Issue

Closes #4065

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added enhancement New feature or request integration/trivy Related to the Trivy integration labels Sep 2, 2024
@nscuro nscuro added this to the 4.12 milestone Sep 2, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.30% (target: -1.00%) 92.04% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e672e6b) 22080 17304 78.37%
Head commit (af64eef) 21909 (-171) 17236 (-68) 78.67% (+0.30%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4116) 113 104 92.04%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 114c6d6 into DependencyTrack:master Sep 2, 2024
11 checks passed
@nscuro nscuro deleted the issue-4065 branch September 2, 2024 21:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request integration/trivy Related to the Trivy integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Trivy integration to use Trivy's gRPC API
1 participant