Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix Slack notifications failing when no base URL is configured #3792

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jun 1, 2024

Description

Fixes Slack notifications failing when no base URL is configured.

See #3742 (comment) for details.

If no base URL is configured, the View Component, View Project, and View Vulnerability buttons will be omitted from the notification. Because they are intended to link back to Dependency-Track, it doesn't make sense to include them without valid URL.

Addressed Issue

Fixes #3742
Backports #3791

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

See DependencyTrack#3742 (comment) for details.

If no base URL is configured, the *View Component*, *View Project*, and *View Vulnerability* buttons will be omitted from the notification. Because they are intended to link back to Dependency-Track, it doesn't make sense to include them without valid URL.

Fixes DependencyTrack#3742

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Jun 1, 2024
@nscuro nscuro added this to the 4.11.2 milestone Jun 1, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8ad00d3) 22074 16780 76.02%
Head commit (a17d9ea) 22074 (+0) 16795 (+15) 76.08% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3792) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro merged commit 1b36d23 into DependencyTrack:4.11.x Jun 1, 2024
5 of 6 checks passed
@nscuro nscuro deleted the backport-pr-3791 branch June 1, 2024 15:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant