Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licenses not being resolved by name #3782

Merged
merged 1 commit into from
May 30, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 30, 2024

Description

Fixes licenses not being resolved by name.

The name was already considered for resolution, but the matching was only performed on license IDs.

Addressed Issue

Fixes #3781

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

The name was already considered for resolution, but the matching was only performed on license IDs.

Fixes DependencyTrack#3781

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label May 30, 2024
@nscuro nscuro added this to the 4.12 milestone May 30, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c64055a) 21667 16425 75.81%
Head commit (27e8a5c) 21667 (+0) 16422 (-3) 75.79% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3782) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro merged commit 09fdec3 into DependencyTrack:master May 30, 2024
12 checks passed
@nscuro nscuro deleted the issue-3781 branch May 30, 2024 08:44
@black-snow
Copy link

Awsome! When can we expect this to be shipped @nscuro ?

@nscuro
Copy link
Member Author

nscuro commented May 30, 2024

There's currently no target date for the 4.12 release, but I'll likely push a 4.11.2 release over the weekend with backports of some recent fixes, including this one.

@black-snow
Copy link

Very much appreciated!

nscuro added a commit to nscuro/dependency-track that referenced this pull request Jun 1, 2024
The name was already considered for resolution, but the matching was only performed on license IDs.

Fixes DependencyTrack#3781
Backports DependencyTrack#3782

Signed-off-by: nscuro <[email protected]>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Jun 1, 2024
The name was already considered for resolution, but the matching was only performed on license IDs.

Fixes DependencyTrack#3781
Backports DependencyTrack#3782

Signed-off-by: nscuro <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to pick up license information
2 participants