Global Audit View: Policy Violations #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances the `getViolations` method in `PolicyViolationResource` to filter the result by ACL and to also allow the use of additional filters, so that a user can get more specific results. Signed-off-by: RBickert <[email protected]>
Adds a new test for `PolicyViolationResource` which tests the filtering by ACL of the newly enhanced `getViolations` method Signed-off-by: RBickert <[email protected]>
Signed-off-by: RBickert <[email protected]>
Signed-off-by: RBickert <[email protected]>
…tions Global Audit View: Policy Violations
1 task
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: RBickert <[email protected]>
Signed-off-by: RBickert <[email protected]>
Signed-off-by: RBickert <[email protected]>
Signed-off-by: rbt-mm <[email protected]>
Signed-off-by: Richard Bickert <[email protected]>
nscuro
requested changes
Sep 22, 2024
src/main/java/org/dependencytrack/resources/v1/PolicyViolationResource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Richard Bickert <[email protected]>
nscuro
approved these changes
Sep 24, 2024
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the
/violationAPI endpoint in the backend to filter the result by ACL and also allow the use of several filters.This enhancement makes it possible to quickly get all policy violations for one's projects and also to only show relevant violations by filtering them as needed. It can either be used directly via the API or through the new Policy Violations Audit view, which is introduced in the frontend PR.
Addressed Issue
#1770
Additional Details
Requires the
VIEW_POLICY_VIOLATIONSpermission.Checklist
- [ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective- [ ] This PR introduces changes to the database model, and I have added corresponding update logic- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly