-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate uploaded BOMs against CycloneDX schema #3218
Comments
+1 on this.
If a 3rd party vendor, supplier, etc. provides a malformed SBOM, giving users the basic data of why and where the problem is would reduce time to remediation/analysis. |
There's plenty of tools to handle sbom validation. Perhaps just a response from dependency track saying "Malformed CycloneDX SBOM". I wouldn't duplicate what other tooling is doing. |
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]>
Closes DependencyTrack#3218 Signed-off-by: nscuro <[email protected]> Signed-off-by: Mikael Carneholm <[email protected]>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Current Behavior
Uploaded BOMs are currently not validated against the CycloneDX schema.
Users who upload (unknowingly) invalid BOMs only get to know about that fact when inspecting the logs of the API server. Further, error logs from the BOM parser can be hard to understand. Instead of spewing out gibberish error messages, it should be stated clearly if the BOM is invalid to begin with.
Proposed Behavior
Validate uploaded BOMs against the CycloneDX schema synchronously, as an additional step of handling upload requests.
Users and clients should know immediately if the uploaded file is invalid and has no chance of being ingested.
This is already implemented in Hyades and merely needs backporting: https://github.com/DependencyTrack/hyades-apiserver/blob/ef39532e0b98962b7fc290902cb33edba52ade51/src/main/java/org/dependencytrack/resources/v1/BomResource.java#L438-L466
Checklist
The text was updated successfully, but these errors were encountered: