-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Withdrawn vulnerabilities still showing up #1693
Comments
Marked as enhancement b/c "handling withdrawn vulnerabilities" appears more like a feature than a defect. In any case, definitely something we should take into account. |
We also noticed this too, sort of pain to address these 'withdrawn' vulnerabilities. It really screws up our metrics gathering and having to explain 'oh no, that one critical vuln is not really a vuln' etc. This is no fault of DT of course. Should we be badgering Github Advisory Database maintainers to remove? |
I do not think that advisories should be removed... that would lead to confusion when vulnerabilities just poof from VEX, etc. I think that it is important to be able to mantain a full audit trail of such "state changes". Remember also that this problem will affect more than just GHSA. I have seen withdrawn CVE. Then there's Snyk, Sonatype OSSIndex, etc. I would expect analyser APIs to handle this, and then DT be able to process things correctly. And maybe it would be possible to also argue for an enhancement to the VEX part of the cyclonedx specification? |
I have done even more thinking (I know, always dangerous). I believe that a fix for this should be done properly and that means a tweak to VEX that would then allow DT to perform more nuance traige. Thus, I logged CycloneDX/specification/issues/168 Perhaps DT could then add functionality to automatically update audit analysis (state) to Rejected? |
@msymons am I assuming correct that this ticket is blocked by CycloneDX/specification#168 or you have planned this already for a specific version. |
@rylyade1, the enhancement request for the specification was added to the v1.5 milestone and a PR raised. An RFC was issued 3 days ago. This will stay open for 28 days (total) before the PR can be merged. The v1.5 specification has an ETA of Q2 2023 (this is not secret... it was in a webinar earlier today 😄 ) Once the specification is implemented then that will inform DT developers on how to correctly go about implementation: how to handle importing VEX and how to generate VEX correctly, whether UI changes are needed, etc Remember also that it might be necessary to chase analysis providers (OSS Index etc) to support provision of such status in their APIs. FYI @ken-duck (Sonatype) |
Same functionality as in the OSV Parser: https://github.com/DependencyTrack/dependency-track/blob/026b504d27c692674eeca0bad32fcb22428b8b02/src/main/java/org/dependencytrack/parser/osv/OsvAdvisoryParser.java#L45-L48 Fixes DependencyTrack#1693 Signed-off-by: Robert Kiss <[email protected]>
Same functionality as in the OSV Parser: https://github.com/DependencyTrack/dependency-track/blob/026b504d27c692674eeca0bad32fcb22428b8b02/src/main/java/org/dependencytrack/parser/osv/OsvAdvisoryParser.java#L45-L48 Fixes DependencyTrack#1693 Signed-off-by: Robert Kiss <[email protected]>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Current Behavior:
Recently I stumpled several times over vulnerabilty reports by Dependency-Track, which are actually withdrawn and marked as such in the vulnerability databases. Dependency-Track does still show these as vulnerable.
For example:
GHSA-8v27-2fg9-7h62
Steps to Reproduce:
Add for example NPM package static-eval 2.1.0 as dependency, and see vulnerability results.
Expected Behavior:
GHSA-8v27-2fg9-7h62 should not be reported, since it is withdrawn.
Environment:
The text was updated successfully, but these errors were encountered: