Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server version comparison #33

Conversation

muellerst-hg
Copy link

assertServerVersionAtLeast(targetVersion string) error should not return error if server version is equal or greater than targetVersion

@muellerst-hg muellerst-hg requested a review from nscuro as a code owner November 6, 2024 12:54
@muellerst-hg muellerst-hg force-pushed the muellerst-fix-server-version-assertion branch 3 times, most recently from 70f999b to 22aaba5 Compare November 6, 2024 13:01
Signed-off-by: Steffen Mueller <[email protected]>
@muellerst-hg muellerst-hg force-pushed the muellerst-fix-server-version-assertion branch from 22aaba5 to e33d68a Compare November 6, 2024 13:02
@nscuro nscuro added the defect Something isn't working label Nov 6, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit 50c5c32 into DependencyTrack:main Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants