Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tamil Translation #334

Merged
merged 4 commits into from
Oct 16, 2022
Merged

Added Tamil Translation #334

merged 4 commits into from
Oct 16, 2022

Conversation

pravee42
Copy link
Contributor

Description

Fixes #

Type of change

  • Added Tamil Translation

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@pravee42
Copy link
Contributor Author

closes #333

@DenverCoder1 DenverCoder1 linked an issue Oct 15, 2022 that may be closed by this pull request
@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Oct 15, 2022
@DenverCoder1 DenverCoder1 self-requested a review October 15, 2022 00:22
@DenverCoder1
Copy link
Owner

DenverCoder1 commented Oct 16, 2022

Hi @pravee42, thanks for the contribution!

I'm noticing that currently the translations are really long and exceed the bounds of the cards.

I was wondering if perhaps there is another way to translate it that could shorten the text?

image

If necessary, I can make a fix that will allow your translations to use two lines instead of one. This still pushes the bounds a little, though, for example:

image

If you could find a way to shorten at least the "current streak" translation while keeping the meaning, that would help.

Let me know if you think that's possible.

@pravee42
Copy link
Contributor Author

Hi @DenverCoder1 I have an idea to change the value like

மிக சமீபத்திய பங்களிப்புகள்

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Oct 16, 2022

@pravee42 Sounds good 👍

Feel free to push it to your patch-1 to update the PR.

Also let me know if you think it will require 2 lines for "longest streak", if so, I can make a fix that will allow that.

@pravee42
Copy link
Contributor Author

Yeah sure

@pravee42
Copy link
Contributor Author

Yes it requires atleast 2 line fir longest streak

src/translations.php Outdated Show resolved Hide resolved
Copy link
Contributor Author

@pravee42 pravee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good you can merge it

src/translations.php Outdated Show resolved Hide resolved
Copy link
Contributor Author

@pravee42 pravee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this Out .

@DenverCoder1
Copy link
Owner

Looks like this now:

image

The longest streak is fine either way since it's ok if it uses 2 lines.

If you think it's better with the extra word, you can put it back, otherwise, let me know and we can merge it like this. 👍

Copy link
Contributor Author

@pravee42 pravee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included that one word as it looks good with that word please review and accept it 😊

Copy link
Contributor Author

@pravee42 pravee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you have mentioned it looks good with that one word so I have again included it

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit 83d9e17 into DenverCoder1:main Oct 16, 2022
@pravee42
Copy link
Contributor Author

Looks great! Thanks for the contribution 🎉

Thanks man it is for the all the Tamil contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local translate to tamil
2 participants