Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added filters in the choices set #148

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Added filters in the choices set #148

merged 2 commits into from
Jan 29, 2023

Conversation

MrDave1999
Copy link
Member

  • This new feature allows the user to write in the component to filter the options from the chatbot.

@MrDave1999
feat: Added filters in the choices set
74d3cc3 
* This new feature allows the user to write in the component to filter the options from the chatbot.
@MrDave1999 MrDave1999 linked an issue Jan 26, 2023 that may be closed by this pull request
Add filters in the choices set #147
Closed
@MrDave1999 MrDave1999 marked this pull request as ready for review January 26, 2023 18:37
@MrDave1999 MrDave1999 marked this pull request as draft January 26, 2023 18:38
@MrDave1999
Copy link
Member Author

MrDave1999 commented Jan 26, 2023 •
edited
Loading

This PR needs review. It has not yet been tested on mobile devices and also the compiler generates some warnings.

@MrDave1999 MrDave1999 added the needs review Issue or pull request that need review or further investigation label Jan 26, 2023
@MrDave1999
Removed filtered style in the patient card
5e975af 
* This style was removed for this card because it does not show the kinship type on mobile devices, this may be due to the full name being too long.
@MrDave1999
Copy link
Member Author

MrDave1999 commented Jan 29, 2023 •
edited
Loading

It works fine on mobile devices and the warnings are generated because the schema has not been updated, i.e. it does not yet allow the filtered style.
These warnings do not impair the operation of the bot, so they can be ignored.

Warning example:

image

@MrDave1999 MrDave1999 removed the needs review Issue or pull request that need review or further investigation label Jan 29, 2023
@MrDave1999 MrDave1999 marked this pull request as ready for review January 29, 2023 18:14
@MrDave1999 MrDave1999 merged commit 461091e into dev Jan 29, 2023
@MrDave1999 MrDave1999 deleted the feature/issue-147 branch January 29, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filters in the choices set
1 participant
@MrDave1999