feat: remove id generation

DenChenn · Sep 14, 2023 · 98e5a91 · 98e5a91
1 parent 01e8b35
commit 98e5a91
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 34 deletions.
diff --git a/README.md b/README.md
@@ -87,6 +87,6 @@ All generated errors implement `blunder.OrdinaryError` interface, which contains
 ```go
 ordinaryError, ok := err.(blunder.OrdinaryError)
 if ok {
-	fmt.Println(ordinaryError.GetId())
+	fmt.Println(ordinaryError.GetMessage())
 }
 ```
diff --git a/internal/codegen/cmd/gen.go b/internal/codegen/cmd/gen.go
@@ -93,12 +93,6 @@ var Gen = &cli.Command{
 		for _, detail := range blunderConfig.Details {
 			errorFilePath := filepath.Join(generatedRootPath, detail.Package, constant.ErrorFileName)
 
-			// generate id for this error according to file path + code
-			for i := range detail.Errors {
-				id := util.GenerateRandomId()
-				detail.Errors[i].Id = id
-			}
-
 			if err := template.Generate(errorFilePath, constant.ErrorFileTemplateFileName, &detail); err != nil {
 				return util.PrintErrAndReturn(err.Error())
 			}

diff --git a/internal/codegen/model/yaml.go b/internal/codegen/model/yaml.go
@@ -10,7 +10,6 @@ type Detail struct {
 }
 
 type ErrorDescription struct {
-	Id             string `yaml:"id"`
 	Code           string `yaml:"code"`
 	HttpStatusCode int    `yaml:"http_status_code"`
 	GrpcStatusCode int    `yaml:"grpc_status_code"`

diff --git a/internal/codegen/template/error.go.tmpl b/internal/codegen/template/error.go.tmpl
@@ -7,7 +7,6 @@ import (
 )
 
 type {{ .Package }} struct {
-  Id             string `json:"id"`
 	HttpStatusCode int    `json:"http_status_code"`
 	GrpcStatusCode int    `json:"grpc_status_code"`
 	ErrorCode      string `json:"error_code"`
@@ -18,7 +17,6 @@ type {{ .Package }} struct {
 var (
   {{- range .Errors }}
 	{{ .Code }} = &{{ $.Package }}{
-    Id:             "{{ .Id }}",
 		HttpStatusCode: {{ .HttpStatusCode }},
 		GrpcStatusCode: {{ .GrpcStatusCode }},
 		ErrorCode:      "{{ .Code }}",
@@ -38,10 +36,6 @@ func (e *{{ .Package }}) Error() string {
 	return e.Message
 }
 
-func (e *{{ .Package }}) GetId() string {
-  return e.Id
-}
-
 func (e *{{ .Package }}) GetHttpStatusCode() int {
 	return e.HttpStatusCode
 }
@@ -65,11 +59,3 @@ func (e *{{ .Package }}) Wrap(err error) {
 func (e *{{ .Package }}) Unwrap() error {
 	return e.Err
 }
-
-func (e *{{ .Package }}) Is(err error) bool {
-  typedErr, ok := err.(*{{ .Package }})
-  if ok {
-    return typedErr.GetId() == e.GetId()
-  }
-  return false
-}
diff --git a/internal/util/id.go b/internal/util/id.go
diff --git a/pkg/blunder/blunder.go b/pkg/blunder/blunder.go
@@ -2,7 +2,6 @@ package blunder
 
 type OrdinaryError interface {
 	Error() string
-	GetId() string
 	GetHttpStatusCode() int
 	GetGrpcStatusCode() int
 	GetErrorCode() string