forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Write the child ownership to ServiceUnitStateChannel
instead of ZK when handling bundle split
#8
Open
Demogorgon314
wants to merge
20
commits into
master
Choose a base branch
from
Demogorgon314/PIP-192-improve-split
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192-improve-split
branch
from
December 9, 2022 10:15
232a27f
to
1a966f1
Compare
Demogorgon314
changed the title
[improve][broker] Write the child ownerships to BSC instead of ZK when split bundle
[improve][broker] Write the child ownerships to ServiceUnitStateChannel instead of ZK when split bundle
Dec 9, 2022
Demogorgon314
changed the title
[improve][broker] Write the child ownerships to ServiceUnitStateChannel instead of ZK when split bundle
[improve][broker] Write the child ownership to Dec 9, 2022
ServiceUnitStateChannel
instead of ZK when handling bundle split
4 tasks
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192-improve-split
branch
from
January 4, 2023 03:24
369c5d4
to
e97ca14
Compare
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192-improve-split
branch
from
January 31, 2023 09:27
e97ca14
to
568a39b
Compare
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelTest.java
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelTest.java
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: apache#16691
Motivation
When the channel handles the split event, we should write the split bundle to zookeeper instead of
ServiceUnitStateChannel
, since we are using theServiceUnitStateChannel
to store the bundle ownership.Modifications
ServiceUnitStateChannel
instead of ZK when handling bundle split.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: