Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Write the child ownership to ServiceUnitStateChannel instead of ZK when handling bundle split #8

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

Demogorgon314
Copy link
Owner

@Demogorgon314 Demogorgon314 commented Dec 9, 2022

Master Issue: apache#16691

Motivation

When the channel handles the split event, we should write the split bundle to zookeeper instead of ServiceUnitStateChannel, since we are using the ServiceUnitStateChannel to store the bundle ownership.

Modifications

  • Write the child ownership to ServiceUnitStateChannel instead of ZK when handling bundle split.
  • Add unit test to cover this change.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@Demogorgon314 Demogorgon314 self-assigned this Dec 9, 2022
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-improve-split branch from 232a27f to 1a966f1 Compare December 9, 2022 10:15
@Demogorgon314 Demogorgon314 changed the title [improve][broker] Write the child ownerships to BSC instead of ZK when split bundle [improve][broker] Write the child ownerships to ServiceUnitStateChannel instead of ZK when split bundle Dec 9, 2022
@Demogorgon314 Demogorgon314 changed the title [improve][broker] Write the child ownerships to ServiceUnitStateChannel instead of ZK when split bundle [improve][broker] Write the child ownership to ServiceUnitStateChannel instead of ZK when handling bundle split Dec 9, 2022
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-improve-split branch from 369c5d4 to e97ca14 Compare January 4, 2023 03:24
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-improve-split branch from e97ca14 to 568a39b Compare January 31, 2023 09:27
# Conflicts:
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelTest.java
# Conflicts:
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelTest.java
# Conflicts:
#	pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant