Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-192: Implement extensible load manager #10

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

Demogorgon314
Copy link
Owner

@Demogorgon314 Demogorgon314 commented Dec 29, 2022

Fixes #xyz

Master Issue: #xyz

PIP: #xyz

Motivation

Implement extensible load manager.

Modifications

For the PIP-192, this PR adds ExtensibleLoadManagerImpl and unit tests.

This PR also changes:

  1. Added CompletableFuture<Optional<LookupResult>> findBrokerServiceUrl( Optional<ServiceUnitId> topic, ServiceUnitId bundle) to LoadManager interface.
  2. Added CompletableFuture<Boolean> checkOwnershipAsync(Optional<ServiceUnitId> topic, ServiceUnitId bundle) to LoadManager interface.
  3. Change CompletableFuture<String> getOwnerAsync(String serviceUnit) to CompletableFuture<Optional<String>> getOwnerAsync(String serviceUnit) to unify the result.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@Demogorgon314 Demogorgon314 self-assigned this Dec 29, 2022
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/Implement_extensible_load_manager branch 3 times, most recently from ce7b30c to 5f44f74 Compare December 29, 2022 07:47
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/Implement_extensible_load_manager branch 4 times, most recently from ee5785f to cf0ad90 Compare January 4, 2023 10:07
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/Implement_extensible_load_manager branch from 6df4f47 to 3765839 Compare January 17, 2023 09:20
…nager

# Conflicts:
#	pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistry.java
#	pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryTest.java
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant