-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
221 name counties during assertion generation step #228
221 name counties during assertion generation step #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and code looks good. What you did was also my interpretation of what they were asking for. I'll make a note to ask Eddie his preferences when he gets back.
addCountiesToSummaries()); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not have a pre-method comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks.
This adds a column in the UI for assertion generation, stating which county the contest is in, or "multiple" if there are multiple. This is in response to a feature request from CDOS.
@charliecarlton I wasn't 100% sure if this was exactly what was wanted. For example, I'm not sure what column order is best. If you get a chance, maybe run it past the CDOS people and ask them if this looks like what they asked for?
The initial state looks like this
and after generation it looks like this