Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

221 name counties during assertion generation step #228

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

vteague
Copy link
Member

@vteague vteague commented Dec 12, 2024

This adds a column in the UI for assertion generation, stating which county the contest is in, or "multiple" if there are multiple. This is in response to a feature request from CDOS.

@charliecarlton I wasn't 100% sure if this was exactly what was wanted. For example, I'm not sure what column order is best. If you get a chance, maybe run it past the CDOS people and ask them if this looks like what they asked for?

The initial state looks like this
generateAssertionsInitial

and after generation it looks like this
generateAssertionsDone

Copy link
Collaborator

@charliecarlton charliecarlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code looks good. What you did was also my interpretation of what they were asking for. I'll make a note to ask Eddie his preferences when he gets back.

addCountiesToSummaries());
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not have a pre-method comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

@vteague vteague merged commit ac60bd5 into main Dec 19, 2024
1 check passed
@vteague vteague deleted the 221-name-counties-during-assertion-generation-step branch December 19, 2024 23:14
@vteague vteague restored the 221-name-counties-during-assertion-generation-step branch December 19, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Name counties during assertion generation step
3 participants