184 change report client UI to put all reports into the same drop down #189
Conversation
…anized into directories).
| * @param raireUrl the url where the raire-service is running | ||
| * Needs to be synchronized just in case someone is foolish enough to call it twice in parallel | ||
| * with the same ZipOutputStream. | ||
| * @param zos an output stream (to become a zip file) | ||
| * @param suffix requested file type: "csv" or "json" | ||
| */ |
There was a problem hiding this comment.
Looks like both directory and prefix in inputs can be final.
| * CSV suffix. | ||
| */ | ||
| final String csv = "csv"; | ||
|
|
There was a problem hiding this comment.
Same comment as on another PR, can the port number be defined in test settings? Otherwise, what if 8111 clashes with something running on someone's computer?
There was a problem hiding this comment.
Good idea - have refactored the TestClassWithDatabase a bit to make sure it does actually read test. properties (which wasn't being read before) and that those port numbers are in there instead of spread all over the different classes.
| * Endpoint for getting assertions. | ||
| */ | ||
| final String getAssertionsEndpoint = "/raire/get-assertions"; | ||
|
|
There was a problem hiding this comment.
It would be clearer to make the suffix constants capitalised.
|
|
||
| /** | ||
| * Test data for the two valid IRV contests, with json and csv. This gives the successfully-sanitized version of | ||
| * the contest names. |
There was a problem hiding this comment.
JSON/CSV extensions are defined as constants but the actual values are used here.
|
|
||
| /** | ||
| * Good urls with bad endpoints. | ||
| */ |
There was a problem hiding this comment.
Same comment as above -- may as well use the defined csv/json constants.
| } | ||
|
|
||
| /** | ||
| * Bad urls. |
There was a problem hiding this comment.
Same comment as above RE csv/json.
vteague
deleted the
184-change-report-client-ui-to-put-all-reports-into-the-same-drop-down
branch
vteague
restored the
184-change-report-client-ui-to-put-all-reports-into-the-same-drop-down
branch
vteague
deleted the
184-change-report-client-ui-to-put-all-reports-into-the-same-drop-down
branch
I modernized the Http calls too.