Block assertion regeneration after audit starts #187
Conversation
…e comparisonaudits in the database. Log when requested.
…AUDIT_INFO_SET states, and not in any other states.
…AUDIT_INFO_SET states, and not in any other states.
|
I can't actually figure out how to test this for the presence of ComparisonAudits, because (quite rightly) it's hard to get it into the state where it has ComparisonAudits but is not in one of the states where assertion generation blocks anyway. |
| * The Generate Assertions endpoint. | ||
| */ | ||
| private final GenerateAssertions endpoint = new GenerateAssertions(); | ||
|
|
There was a problem hiding this comment.
Might be worth, for anyone reading this, to have some more detail about the parameters being supplied to the GenerateAssertionsResponse/Request parameters. eg. "Mock response for tinyExample1 contest where X is true and Y is false" or something like that. And similarly for the request, "Request for tinyExample1 contest with an allowed time of 5 seconds."
| * Raire endpoint for getting assertions. | ||
| */ | ||
| private final String raireGenerateAssertionsEndpoint = "/raire/generate-assertions"; | ||
|
|
There was a problem hiding this comment.
Can the port be specified somewhere else in settings ... what if 8110 clashes with something else someone is running?
There was a problem hiding this comment.
Excellent idea; done in the other PR.
…sertion-regeneration-after-audit-starts # Conflicts: # server/eclipse-project/src/main/java/au/org/democracydevelopers/corla/endpoint/GenerateAssertions.java
Along with tests that the two allowed ASM states work and the others throw an exception.