Updated - and greatly simplified - GenerateAssertionsResponse. Now ju… #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st the contest name and two booleans: did it succeed? and is it worth retrying?
|
This matches the corresponding PR in the raire-service. |
charliecarlton
approved these changes
Aug 7, 2024
michelleblom
approved these changes
Aug 9, 2024
| @@ -177,22 +175,20 @@ public String endpointBody(final Request the_request, final Response the_respons | |||
| * - Gather all the IRVContestResults | |||
| * - For each IRV contest, make a request to the raire-service get-assertions endpoint of the right format type | |||
| * - Collate all the results into a list. | |||
| * | |||
| * @param IRVContestResults the collection of all IRV ContestResults. | |||
| * @param timeLimitSeconds the time limit for raire assertion generation, per contest. | |||
| * @param raireUrl the url where the raire-service is running. | |||
There was a problem hiding this comment.
I'm guessing these input arguments can be final?
| * @return The GenerateAssertionsResponseWithErrors, which usually contains a | ||
| * winner but may instead be UNKNOWN_WINNER and an error message. | ||
| * @return The GenerateAssertionsResponseWithErrors, which usually contains a | ||
| * winner but may instead be UNKNOWN_WINNER and an error message. |
There was a problem hiding this comment.
Check input arguments for what can be final.
vteague
deleted the
173-change-generate-assertions-http-response-to-status-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st the contest name and two booleans: did it succeed? and is it worth retrying?
This makes everything a lot simpler, though it will get more complicated again when we want to retrieve winners and errors from the database.