100 persist irvballotinterpretation #155
Conversation
…00-persist-irvballotinterpretation # Conflicts: # server/eclipse-project/src/main/resources/us/freeandfair/corla/persistence/entity_classes
| @Version | ||
| @Column(name = "version", updatable = false, nullable = false) | ||
| private long version; | ||
|
|
There was a problem hiding this comment.
If this is meant to be a non-updatable data structure, then it is odd to have non final public attributes. I would make them private and just have getters for the required fields.
| */ | ||
| public IRVBallotInterpretation() { | ||
| } | ||
|
|
There was a problem hiding this comment.
Worth adding in the comments that we are creating a record of an interpretation of an invalid IRV vote.
| * @param imprintedId the imprinted ID, i.e. tabulator_id-batch_id-record_id. | ||
| * @param rawChoices the (invalid) raw IRV choices, e.g. [Bob(1),Alice(3),Chuan(4)]. | ||
| * @param orderedChoices the way colorado-rla interpreted the raw choices, as an order list of names. | ||
| */ |
There was a problem hiding this comment.
Does line 99 fall within the line length guideline?
| * during the auditing steps, a record is made of the CVR ID, the county, contest name, raw vote, | ||
| * and our interpretation of that vote as an ordered list of candidate names. | ||
| * This is output as a report called IRVBallotInterpretationReport. | ||
| */ |
There was a problem hiding this comment.
Check whether we need this to implement the Serializable interface in addition to PersistentEntity. If not, some of the methods can be removed if we don't implement it.
There was a problem hiding this comment.
I got rid of Serizalizable but unfortunately those 3 overridden messages are still needed for PersistentEntity.
| this.rawChoices = rawChoices; | ||
| this.interpretation = orderedChoices; | ||
| } | ||
|
|
There was a problem hiding this comment.
"Output details of the stored IRV vote interpretation as a String ..."
|
|
||
| // Make the ranked_ballot_interpretation report. | ||
| final Map<String, String> files = ExportQueries.sqlFiles(); | ||
| final ByteArrayOutputStream os = new ByteArrayOutputStream(); |
There was a problem hiding this comment.
Check whether non-final declared variables can be made final.
| @@ -92,6 +102,14 @@ public class GetAssertionsTests { | |||
| */ | |||
There was a problem hiding this comment.
The baseURL attribute is just labelled 'static' without a private/public etc.
|
|
||
| /** | ||
| * Test that a correct ranked vote interpretation report is produced, for a variety of IRV-related | ||
| * parsing examples, including: |
|
|
||
| /** | ||
| * Class-wide logger | ||
| */ |
There was a problem hiding this comment.
Generally we don't have the au.org. etc prefix for the Class.class statement here.
|
|
||
| DominionCVRExportParser parser = new DominionCVRExportParser(reader, fromString("Gilpin"), blank, true); | ||
| assertTrue(parser.parse().success); | ||
|
|
There was a problem hiding this comment.
Should q and cvr be final?
This adds a new database table for persisting the valid interpretations of invalid IRV ballots. This is not actually used in the RLA computation, but is reported in its own report (also part of this PR).
Note this only deals with the UPLOAD Cvrs - the audit CVRs will need to be added, too, but that is in a separate card.