Irv audit ballot UI #154
Closed
Irv audit ballot UI #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vteague
approved these changes
Jul 22, 2024
| key={ranking.value} | ||
| value={ranking.value} | ||
| disabled={noConsensus} | ||
| checked={checked || false} |
There was a problem hiding this comment.
Is there a reason {checked || false} isn't identical to checked?
There was a problem hiding this comment.
Ans: (Charlie) yes because checked might be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I think I messed up my first attempt at making the pull request. This is at least the first iteration of the irv audit ballot form based off of some mockups from the web team at CDOS. definitely open to any and all feedback on it. thanks!