Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

93 pass metadata between objects #131

Merged
merged 36 commits into from
Aug 11, 2023
Merged

93 pass metadata between objects #131

merged 36 commits into from
Aug 11, 2023

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Aug 9, 2023 •
edited
Loading

User impact:

  • metadata, vertref and station metadata cannot be provided to write_components, write_tsdia, write_tsdia_HWLW in user script anymore, metadata is now derived from component/timeseries files.
  • improved metadata/header in component files
  • reading files written with hatyan<=2.7.0 contain no metadata in header, it will give a warning and the returned object will contain no metadata

@veenstrajelmer veenstrajelmer linked an issue Aug 9, 2023 that may be closed by this pull request
Pass metadata between objects #93
Closed
16 tasks
@veenstrajelmer veenstrajelmer mentioned this pull request Aug 9, 2023
Closed
96 tasks
@veenstrajelmer
fixed some example scripts and removed return_prediction
d4b894c
@veenstrajelmer
fixed many example scripts
1ac909c
@veenstrajelmer
Merge branch 'main' into 93-pass-metadata-between-objects
ded8a54
@veenstrajelmer
merged meta scripts
d83aa97
@veenstrajelmer
wns from other metadata, applied everywhere
1741327
@veenstrajelmer
fixed unittests
184bea2
@veenstrajelmer
fixed diawia example script
6e75875
@veenstrajelmer
only popping keys if present
8c42a66
@veenstrajelmer
reverted
10ee0cb
@veenstrajelmer
added metadata process testcase
fc81d4f
@veenstrajelmer
do not allow empty metadata
58909c8
@veenstrajelmer
removed metadummy from example files and testcase
8e64e09
@veenstrajelmer
allow no metadata in merge_componentgroups
e494f53
@veenstrajelmer
Merge branch 'main' into 93-pass-metadata-between-objects
342048c
@veenstrajelmer
updated to no stat/vertref for write_tsdia
16760c5
@veenstrajelmer
testcase to correct file
463fe1f
@veenstrajelmer
added testcase
328d3bc
@veenstrajelmer
updated example script
0eb6cc2
@veenstrajelmer
removed temp example script
19d1404
@veenstrajelmer
updated example script
7c6d1c7
@veenstrajelmer
updated example script
46e329d
@veenstrajelmer
added metadata to timeseries_crop and timeseries_resample, including …
e94b702 
…testcases
@veenstrajelmer veenstrajelmer merged commit 227483b into main Aug 11, 2023
@veenstrajelmer veenstrajelmer deleted the 93-pass-metadata-between-objects branch August 11, 2023 13:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass metadata between objects
1 participant
@veenstrajelmer