Update modelbuilder_example.ipynb #1040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salinity and temperature processes turned on in the mdu block
|
|
@lorincmeszaros merely adding salinity and temperature won't do the trick, as it only makes sense to add these if there are vertical layers present in the model. A few months ago I made an overview with @srodrigo-deltares what is required to go from 2D to 3D: #951. I think it would be more useful to prioritize this issue instead. Therefore, I will close this PR now, but feel free to re-open if you think that is better and let's discuss in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salinity and temperature processes turned on in the mdu block