Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required states sbm_gwf model type #424

Merged
merged 4 commits into from
May 30, 2024
Merged

Fix required states sbm_gwf model type #424

merged 4 commits into from
May 30, 2024

Conversation

verseve
Copy link
Member

@verseve verseve commented May 29, 2024 •
edited
Loading

Issue addressed

Fixes #423

Explanation

See issue.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

@verseve verseve self-assigned this May 30, 2024
@verseve verseve requested a review from JoostBuitink May 30, 2024 09:55
JoostBuitink
JoostBuitink approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@verseve verseve merged commit 447867c into master May 30, 2024
10 checks passed
@verseve verseve deleted the fix_required_states_sbm-gwf branch May 30, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoostBuitink JoostBuitink JoostBuitink approved these changes

Assignees

@verseve verseve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

States checking for model type sbm_gwf is missing required river and land state :h_av
2 participants
@verseve @JoostBuitink