Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBM evaporation and use of fractions #381

Merged
merged 9 commits into from
Apr 8, 2024
Merged

SBM evaporation and use of fractions #381

merged 9 commits into from
Apr 8, 2024

Conversation

verseve
Copy link
Member

@verseve verseve commented Mar 26, 2024

Issue addressed

Fixes #374

Explanation

See issue #374

Checklist

  • Updated tests or added new tests
  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

Always use the fraction (`riverfrac`, `waterfrac`, `canopygapfraction` and bare soil) to divide potential evaporation over different processes (interception, transpiration, soil evaporation and open water evaporation).
For computation of `ewet` the crop coefficient `kc` should be used, and for `e_r` the canopy fraction should be used for the precipitation amount.
@verseve verseve marked this pull request as ready for review March 28, 2024 09:01
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this! It looks like with these new fixes more water can evaporate from the soil column, rather than having most PET being "removed" by the canopy (in the old configuration). This new implementation seems more realistic!

Besides `riverfrac` and `waterfrac` also include `glacierfrac` to correct `canopygapfraction` for soil evaporation.
@verseve verseve merged commit c886aa2 into master Apr 8, 2024
8 of 10 checks passed
@verseve verseve deleted the evap_fracs branch April 9, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBM evaporation and fractions (open water, vegetation, soil surface)
2 participants