Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spelling and grammar in the user guide #379

Merged
merged 9 commits into from
Mar 26, 2024

Conversation

CFBaptista
Copy link
Contributor

This PR updates the spelling and grammar in the User guide section of the Wflow documentation.
This resolves one of the tasks in issue #377, namely the update of the User guide section.
As I joined the team this week I have been reading the documentation in sequential order from front to back and along the way I commit languages changes.

@CFBaptista CFBaptista added documentation Improvements or additions to documentation v1.0 Activities related to v1.0 labels Mar 21, 2024
Copy link
Member

@verseve verseve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One suggestion is to always use wflow (we agreed on this for the product name a couple of years ago), except at the start of a sentence. I did catch a few, there might be more in the docs.


Example models can be found in the [Example model section](@ref sample_data).

## hydroMT
[hydroMT](https://github.com/Deltares/hydromt) is a Python package, developed by Deltares,
to build and analysis hydro models. It provides a generic model api with attributes to
to build and analyze hydro models. It provides a generic model api with attributes to
access the model schematization, (dynamic) forcing data, results and states.

For the following Wflow models:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For the following Wflow models:
For the following wflow models:


Example models can be found in the [Example model section](@ref sample_data).

## hydroMT
[hydroMT](https://github.com/Deltares/hydromt) is a Python package, developed by Deltares,
to build and analysis hydro models. It provides a generic model api with attributes to
to build and analyze hydro models. It provides a generic model api with attributes to
access the model schematization, (dynamic) forcing data, results and states.

For the following Wflow models:
- wflow\_sbm + kinematic wave
- wflow_sediment

the Wflow plugin [hydroMT-wflow](https://github.com/Deltares/hydromt_wflow) of hydroMT can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the Wflow plugin [hydroMT-wflow](https://github.com/Deltares/hydromt_wflow) of hydroMT can
the wflow plugin [hydroMT-wflow](https://github.com/Deltares/hydromt_wflow) of hydroMT can

access the model schematization, (dynamic) forcing data, results and states.

For the following Wflow models:
- wflow\_sbm + kinematic wave
- wflow_sediment

the Wflow plugin [hydroMT-wflow](https://github.com/Deltares/hydromt_wflow) of hydroMT can
be used to build and analyse these Wflow model types in an automated way.
be used to build and analyze these Wflow model types in an automated way.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
be used to build and analyze these Wflow model types in an automated way.
be used to build and analyze these wflow model types in an automated way.

@@ -6,7 +6,7 @@ The filepaths that are provided in this file are relative to the location of the
or to `dir_input` and `dir_output` if they are given.

## General time info
Time information is optional. When left out, for each timestamp in the forcing NetCDF Wflow
Time information is optional. When left out, for each timestamp in the forcing netCDF Wflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Time information is optional. When left out, for each timestamp in the forcing netCDF Wflow
Time information is optional. When left out, for each timestamp in the forcing netCDF wflow

information is left out from the TOML configuration file, the `starttime`, `endtime` and
`timestepsecs` (timestep) of the run is extracted from the NetCDF forcing file by Wflow.
`timestepsecs` (timestep) of the run is extracted from the netCDF forcing file by Wflow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`timestepsecs` (timestep) of the run is extracted from the netCDF forcing file by Wflow.
`timestepsecs` (timestep) of the run is extracted from the netCDF forcing file by wflow.

Copy link
Member

@verseve verseve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CFBaptista CFBaptista merged commit cd36547 into master Mar 26, 2024
10 checks passed
@verseve verseve deleted the doc/improve_spelling_and_grammar_in_user_guide branch June 3, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v1.0 Activities related to v1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants