Remove lower limit of zero for sbm.runoff
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting a lower limit of zero for `sbm.runoff` originates from the wflow_sbm Python implementation, when surface runoff was computed with one kinematic wave, to avoid a very slow kinematic wave solution. In the Python code the kinematic wave was split into a river and land component. While for river runoff the lower limit was removed, this was not done for land runoff yet.
Compute mean values of variables runoff, soilevap and snow, and add variables actevap and actinfilt.
CFBaptista
requested review from
CFBaptista
and removed request for
JoostBuitink
CFBaptista
approved these changes
Apr 4, 2024
JoostBuitink
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Based on a discussion with @verseve, we decided to tackle this in a slightly different way, in order to be consistent with runoff_river and net_runoff_river. In the runoff variable, we do not subtract the ea_openw_l variable, and the net_runoff will become equal to runoff - ae_openw_l. This would require a bit more changes, to ensure that the net_runoff will be used throughout the code.
JoostBuitink
approved these changes
Apr 8, 2024
Co-authored-by: JoostBuitink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #372
Explanation
See #372.
Checklist
master