Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI tests #366

Merged
merged 24 commits into from
Mar 14, 2024
Merged

Add CLI tests #366

merged 24 commits into from
Mar 14, 2024

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Mar 4, 2024

Explanation

  • Add CLI tests
  • Track Manifest files
  • Move downloading test data to own file
  • Add pixi tasks

Checklist

  • Updated tests or added new tests
  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

.gitignore Outdated Show resolved Hide resolved
pixi.toml Show resolved Hide resolved
@JoostBuitink
Copy link
Contributor

@Hofer-Julian, it appears the the WflowServer tests here use the master branch and not the code from this branch. Do you know why this is happening?

server/test/client.jl Outdated Show resolved Hide resolved
@Hofer-Julian
Copy link
Contributor Author

@Hofer-Julian, it appears the the WflowServer tests here use the master branch and not the code from this branch. Do you know why this is happening?

I don't see how that could happen

@JoostBuitink JoostBuitink merged commit 105d99d into master Mar 14, 2024
9 of 10 checks passed
@JoostBuitink JoostBuitink deleted the add-cli-tests branch March 14, 2024 07:58
@JoostBuitink
Copy link
Contributor

@Hofer-Julian, it appears the the WflowServer tests here use the master branch and not the code from this branch. Do you know why this is happening?

I don't see how that could happen

Just for completeness (as it was already discussed on Teams); I have added a dev install in the pixi task that fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants