Check lake balance #330
Merged
Check lake balance #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on total available volume (storage, inflow and precipitation).
Based on total available volume (storage, inflow and precipitation).
Limit lake outflow by lake storage, and check if solution term of quadratic equations is above zero.
Lake and reservoir module.
JoostBuitink
approved these changes
Jan 30, 2024
| @@ -147,7 +148,8 @@ between parentheses. | |||
| | `outflow` | outflow lake | m``^3`` s``^{-1}`` | - | | |||
| | `totaloutflow` | total outflow lake | m``^3`` | - | | |||
| | `precipitation` | average precipitation for lake area | mm Δt⁻¹ | - | | |||
| | `evaporation` | average precipitation for lake area | mm Δt⁻¹ | - | | |||
| | `evaporation` | average evaporation for lake area | mm Δt⁻¹ | - | | |||
There was a problem hiding this comment.
Suggested change
| | `evaporation` | average evaporation for lake area | mm Δt⁻¹ | - | | |
| | `evaporation` | average potential evaporation for lake area | mm Δt⁻¹ | - | |
src/reservoir_lake.jl
Outdated
| @@ -14,6 +14,7 @@ | |||
| demandrelease::Vector{T} | "m3 s-1" # minimum (environmental) flow released from reservoir [m³ s⁻¹] | |||
| precipitation::Vector{T} # average precipitation for reservoir area [mm Δt⁻¹] | |||
| evaporation::Vector{T} # average evaporation for reservoir area [mm Δt⁻¹] | |||
There was a problem hiding this comment.
Suggested change
| evaporation::Vector{T} # average evaporation for reservoir area [mm Δt⁻¹] | |
| evaporation::Vector{T} # average potential evaporation for reservoir area [mm Δt⁻¹] |
src/reservoir_lake.jl
Outdated
| @@ -222,6 +224,7 @@ end | |||
| totaloutflow::Vector{T} | "m3" # total outflow lake [m³] | |||
| precipitation::Vector{T} # average precipitation for lake area [mm Δt⁻¹] | |||
| evaporation::Vector{T} # average evaporation for lake area [mm Δt⁻¹] | |||
There was a problem hiding this comment.
Suggested change
| evaporation::Vector{T} # average evaporation for lake area [mm Δt⁻¹] | |
| evaporation::Vector{T} # average potential evaporation for lake area [mm Δt⁻¹] |
To clarify parameter descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #329
Explanation
See the updated changelog.
Checklist
master