Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BMI get_grid_size function #328

Merged
merged 3 commits into from
Jan 17, 2024
Merged

BMI get_grid_size function #328

merged 3 commits into from
Jan 17, 2024

Conversation

verseve
Copy link
Member

@verseve verseve commented Jan 16, 2024

Issue addressed

No issue reported.

Explanation

See comment first commit and updated changelog.

Checklist

  • Updated tests or added new tests
  • Branch isx up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

@verseve
Add BMI get_grid_size function
9a6f9dc 
Is used for unstructured grids, for example for BMI functions `get_grid_x` and `get_grid_y` (length of array returned).
@verseve
Add get_grid_size test
02fdf49
@verseve
Update changelog
0278c4e
@verseve verseve self-assigned this Jan 16, 2024
@verseve verseve requested a review from dalmijn January 17, 2024 09:35
dalmijn
dalmijn approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@dalmijn dalmijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally (manually), seems good to me.

JoostBuitink
JoostBuitink approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@verseve verseve merged commit b336f27 into master Jan 17, 2024
12 checks passed
@verseve verseve deleted the bmi_grid_size branch January 17, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalmijn dalmijn dalmijn approved these changes

@JoostBuitink JoostBuitink JoostBuitink approved these changes

Assignees

@verseve verseve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@verseve @JoostBuitink @dalmijn