Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kvfrac leakage #325

Merged
merged 5 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/src/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
outflow variables are defined for period `Δt`, and not at `t1` and `t2` (instantaneous) as
in the original mass balance equation of the Modified Puls Approach. Because of this, the
terms of the quadratic equation (and solution) were fixed.
- Use `kvfrac` for the computation of vertical saturated hydraulic conductivity at the
bottom of the soil layer, since `kvfrac` is also used for the computation of vertical
unsaturated flow.

### Changed
- For cyclic parameters different cyclic time inputs are supported (only one common cyclic
Expand Down
2 changes: 1 addition & 1 deletion docs/src/model_docs/params_lateral.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ scales (hillslope) in reality, not represented by the model resolution.
| `dw` | drain width | m | - |
| `zi` | pseudo-water table depth (top of the saturated zone) | m | - |
| `exfiltwater` | exfiltration (groundwater above surface level, saturated excess conditions) | m Δt⁻¹ | - |
| `recharge` | net recharge to saturated store | m Δt⁻¹ | - |
| `recharge` | net recharge to saturated store | m``^2`` Δt⁻¹ | - |
| `ssf` | subsurface flow | m``^3`` d``{-1}`` | - |
| `ssfin` | inflow from upstream cells | m``^3`` d``{-1}`` | - |
| `ssfmax` | maximum subsurface flow | m``^2`` d``{-1}`` | - |
Expand Down
2 changes: 1 addition & 1 deletion src/flow.jl
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ end
dw::Vector{T} | "m" # Flow width [m]
zi::Vector{T} | "m" # Pseudo-water table depth [m] (top of the saturated zone)
exfiltwater::Vector{T} | "m Δt-1" # Exfiltration [m Δt⁻¹] (groundwater above surface level, saturated excess conditions)
recharge::Vector{T} | "m Δt-1" # Net recharge to saturated store [m Δt⁻¹]
recharge::Vector{T} | "m2 Δt-1" # Net recharge to saturated store [m² Δt⁻¹]
ssf::Vector{T} | "m3 d-1" # Subsurface flow [m³ d⁻¹]
ssfin::Vector{T} | "m3 d-1" # Inflow from upstream cells [m³ d⁻¹]
ssfmax::Vector{T} | "m2 d-1" # Maximum subsurface flow [m² d⁻¹]
Expand Down
2 changes: 1 addition & 1 deletion src/sbm.jl
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ function update_until_recharge(sbm::SBM, config)
actcapflux = actcapflux + toadd
end
end
deepksat = sbm.kv₀[i] * exp(-sbm.f[i] * sbm.soilthickness[i])
deepksat = sbm.kvfrac[i][end] * sbm.kv₀[i] * exp(-sbm.f[i] * sbm.soilthickness[i])
deeptransfer = min(satwaterdepth, deepksat)
actleakage = max(0.0, min(sbm.maxleakage[i], deeptransfer))

Expand Down
Loading