Move wflow_cli code from GitLab #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Largely copied from Ribasim.jl, need to check if all code from wflow_cli/create_app is covered
evetion
requested changes
Jul 27, 2023
| @@ -0,0 +1,28 @@ | |||
| # ensure both projects are up to date | |||
There was a problem hiding this comment.
Is this file needed? We could just call create_app directly (as we do in Ribasim).
There was a problem hiding this comment.
It looked like this was the original file that was used to do the building (as we need/expect the test data to be there, for precompiling). I now merged this code into the create_app script
build/wflow_cli/Dockerfile
Outdated
| @@ -0,0 +1,11 @@ | |||
| FROM julia:1.8.2 | |||
.gitignore
Outdated
| @@ -21,3 +21,6 @@ | |||
| /dev/ | |||
| /test/data/ | |||
| /tmp/ | |||
|
|
|||
| # Build files | |||
| /build/create_binaries/wflow_cli/ | |||
There was a problem hiding this comment.
Many files are missing EOF (blank line at end of file), indicated by the red sign.
There was a problem hiding this comment.
Thanks for spotting this. It should be fixed now!
evetion
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #274
Explanation
Copied code from GitLab to a
buildfolder. Followed the structure from Ribasim.jl, also to allow for easier adding a libwflow in the future.Checklist
masterAdditional Notes (optional)
The code to create the installer is also included in the build folder. This code can be used by TeamCity to build the installers.