-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve overhead Threads.@threads
(> 8 threads)
#261
Commits on May 10, 2023
-
threads and basesize (vertical and kin-wave)
Make use of Threads.@Spawn and basesize to have more control on the amount of work per thread. Added this for vertical and kinematic wave routing components.
Configuration menu - View commit details
-
Copy full SHA for f59cac8 - Browse repository at this point
Copy the full SHA f59cac8View commit details -
Threads.@Spawn
for local inertial routingand removed eachindex when not required
Configuration menu - View commit details
-
Copy full SHA for caab73f - Browse repository at this point
Copy the full SHA caab73fView commit details -
Use only catchment scale stream order to partition river and land domain for parallel running of kinematic wave solution. Different minimum stream order values can be supplied for the river and land domain.
Configuration menu - View commit details
-
Copy full SHA for 466abdb - Browse repository at this point
Copy the full SHA 466abdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c349e8 - Browse repository at this point
Copy the full SHA 9c349e8View commit details -
SurfaceFlow is used for both kinematic wave river and overland flow. This is now split into structs SurfaceFlowRiver and SurfaceFlowLand. It simplifies the orginal update function (split into two, logic easier to follow), and dispatching on these types is easier (e.g. for BMI to extract relevant properties as grid type).
Configuration menu - View commit details
-
Copy full SHA for 07e8eb5 - Browse repository at this point
Copy the full SHA 07e8eb5View commit details -
fix threading kinematic wave overland flow
use threaded_foreach instead of @threads
Configuration menu - View commit details
-
Copy full SHA for 5523c23 - Browse repository at this point
Copy the full SHA 5523c23View commit details -
For threading use spawn tasks and Polyester threads
For threads <= 8 spawn tasks is used (outperforms Polyester threads in this range), and for threads > 8 Polyester threads is used (spawn tasks slows down in this range).
Configuration menu - View commit details
-
Copy full SHA for 5a8f671 - Browse repository at this point
Copy the full SHA 5a8f671View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78f58f7 - Browse repository at this point
Copy the full SHA 78f58f7View commit details -
performance floodplain routing
Reduce run time by applying loopvectorization only for edges above flow threshold and by pre-allocating more variables (river and floodplain).
Configuration menu - View commit details
-
Copy full SHA for ef29614 - Browse repository at this point
Copy the full SHA ef29614View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa55d67 - Browse repository at this point
Copy the full SHA fa55d67View commit details -
Use
@batch
for 2D local inertial flowand stable_timestep calculation is now faster with @tturbo.
Configuration menu - View commit details
-
Copy full SHA for ded90d1 - Browse repository at this point
Copy the full SHA ded90d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c399d4e - Browse repository at this point
Copy the full SHA c399d4eView commit details -
and rename variable index of struct FloodPlain
Configuration menu - View commit details
-
Copy full SHA for 9b31cdc - Browse repository at this point
Copy the full SHA 9b31cdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f1eab3 - Browse repository at this point
Copy the full SHA 4f1eab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf5406 - Browse repository at this point
Copy the full SHA dcf5406View commit details
Commits on May 11, 2023
-
update docs and remove field
to_river
fromSurfaceFlowRiver
- update model parameters docs because of split of struct SurfaceFlow in river and overland flow structs. - remove field to_river from struct SurfaceFlowRiver (not used as part of river flow).
Configuration menu - View commit details
-
Copy full SHA for 95f5867 - Browse repository at this point
Copy the full SHA 95f5867View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00e5205 - Browse repository at this point
Copy the full SHA 00e5205View commit details
Commits on May 16, 2023
-
For Julia version < 1.8 Base.ifelse is not working with Loopvectorization (`LoopVectorization.check_args` on your inputs failed).
Configuration menu - View commit details
-
Copy full SHA for 3011453 - Browse repository at this point
Copy the full SHA 3011453View commit details
Commits on Jun 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f8c5cb7 - Browse repository at this point
Copy the full SHA f8c5cb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 829ec98 - Browse repository at this point
Copy the full SHA 829ec98View commit details